Subject: Re: Rev 1.19 of busdma.doc
To: Bill Sommerfeld <sommerfeld@orchard.medford.ma.us>
From: Justin T. Gibbs <gibbs@freefall.freebsd.org>
List: tech-kern
Date: 11/09/1996 16:54:04
>One comment:
>
>Since the `op' argument to bus_dmamap_sync is most likely going to be
>a compile-time constant at each call site, from the sake of
>microefficiency, it might be better to have four distinct
>bus_dmamap_sync ops ..
>
>	bus_dmamap_sync_preread()
>	bus_dmamap_sync_postread()
>	bus_dmamap_sync_prewrite()
>	bus_dmamap_sync_postwrite()
>
>					- Bill

If the 'op' is a compile-time constant and the "function" is either inline
or a macro, you get the same effect without having to expand the name space
of the API for each new 'op' you may add.

--
Justin T. Gibbs
===========================================
  FreeBSD: Turning PCs into workstations
===========================================