Re: net/mosh breakage on Darwin (-current)

[Jason Bacon <jtocino%gmx.com@localhost>]

On 11/10/23 01:15, Manuel Kuklinski wrote:
> Am Donnerstag 9 November 2023 um 21:00:11 +0100, schrieb Manuel Kuklinski 1,3K:
> > Now, the next error is a missing header file on Darwin, namely
> > "execinfo.h".
>
> Hi!
>
> mk ~/pkgsrc/pkgsrc $ cvs diff net/mosh/Makefile
> Index: net/mosh/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/net/mosh/Makefile,v
> retrieving revision 1.36
> diff -r1.36 Makefile
> 13,14c13,14
> < USE_TOOLS+=       perl:run pkg-config
> < USE_LANGUAGES+=       c c++
> ---
> > USE_TOOLS+=       perl:run pkg-config gmake
> > USE_LANGUAGES+=       c c++14
> 17,18d16
> < USE_CXX_FEATURES+=    c++14
> <
> 28a27,28
> > .include "../../mk/bsd.prefs.mk"
> 33a34,36
> > .if ${OPSYS} == "Darwin"
> > .include "../../devel/libexecinfo/buildlink3.mk"
> > .endif
>
> Builds sucessfully on Darwin 23.1.0.
>
> Kind regards.

Nice work...

A few more things:

1. USE_TOOLS should be alphabetized for easier reading.

2. You don't need to wrap the include of devel/libexecinfo.  Pkgsrc
should detect a builtin version automatically using builtin.mk.

3. When referring to macOS versions, it's more useful to use sw_vers,
rather than uname (which reports the kernel version, not the OS
version).  Pkgsrc ${OS_VERSION} is based on sw_vers.  Darwin 23 equates
to macOS 14 here.

I added wip/mosh to facilitate more testing.  It builds for me on NetBSD
9, macOS 12 and 14, and Alma 8.