Joerg Sonnenberger <joerg%britannica.bec.de@localhost> writes: > On Thu, Jun 18, 2015 at 08:11:54AM +0000, David Holland wrote: >> > I agree; more than document it should fail hard. It's really not >> > ok for pkgsrc to prohibit symlinks, and I view that as a bug that hasn't >> > been fixed. >> >> It's not really fixable; you need to hunt down all the possible >> pathnames that might refer to these directories and load them all into >> the wrappers for matching and substitution. Otherwise, any tool that >> manages to come up with one of the alternate names somehow will >> silently bypass wrapper protection and strange things will happen. > > ...and of course, buildlink and xlinks are themselve using symlinks, so > just resolving them is not going to work either. All to "fix" something > which is a configuration problem in first place. I'm talking about situations where pkgsrc is really in ~/NetBSD-current/pkgsrc and /usr/pkgsrc is a symlink to it, or something like that. That's not a configuration problem; it's been within normal unix practice for decades. But, I see the point that it's infeasible to make wrappers work in the presence of PWD being odd. So we're reduced to failing in that case - and it would be good to fail hard and obvious rather than lead to unclear problems. It's easy enough to "cd `/bin/pwd -P`" before starting. So perhaps erroring out early if $PWD does not equal `/bin/pwd -P` would be sufficient. Or perhaps a remedial cd with a warning.
Attachment:
pgpPoPErmyTXY.pgp
Description: PGP signature