pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

(pkglint) OVERRIDE_GEMSPEC is modified using "+=", its name should indicate plural.



I have pkglint warning, for example at net/ruby-twitter
 WARN: Makefile:12: As OVERRIDE_GEMSPEC is modified using "+=", its name should 
indicate plural.

Which do you like ?
(1) Ignore this message.
(2) Rename OVERRIDE_GEMSPEC to OVERRIDE_GEMSPECS.
    .. I consulted with dictionary getting plural of specification
    is specifications ..
(3) Change += to =   (But not to follow help as described:)
   make help topic=OVERRIDE_GEMSPEC
(4) Fix pkglint (but how ?)

If we take (2),  the diff is at
  http://www.ki.nu/~makoto/pkgsrc/OVERRIDE_GEMSPEC
  wc shows the number as
  586    1790   21085 /home/makoto/public_html/pkgsrc/OVERRIDE_GEMSPEC
 (This does not include adding '+' for 'OVERRIDE_GEMSPEC= ' case)

This is alternative patch to change = to += as well:
  http://www.ki.nu/~makoto/pkgsrc/OVERRIDE_GEMSPEC-plus

List of affected files: 
------------------------
databases/ruby-activerecord-odbc/Makefile
databases/ruby-cassandra/Makefile
databases/ruby-dm-core/Makefile
databases/ruby-dm-serializer/Makefile
devel/ruby-cmd/Makefile
devel/ruby-debug-base/Makefile
devel/ruby-debug-ide/Makefile
devel/ruby-debug/Makefile
devel/ruby-ffi/Makefile
devel/ruby-hashery/Makefile
devel/ruby-priority-queue/Makefile
devel/ruby-railties32/Makefile
devel/ruby-rake/Makefile
devel/ruby-rspec-expectations/Makefile
devel/ruby-uglifier/Makefile
graphics/ruby-imlib2/Makefile
lang/ruby/gem.mk
net/ruby-net-ping/Makefile
net/ruby-soap4r/Makefile
net/ruby-twitter-stream/Makefile
security/ruby-ezcrypto/Makefile
textproc/ruby-json-utils/Makefile
www/heel/Makefile
www/ruby-coffee-rails32/Makefile
www/ruby-faraday/Makefile
www/ruby-padrino-core/Makefile
www/ruby-padrino-mailer/Makefile
www/ruby-rack/Makefile
www/ruby-rack14/Makefile
www/thoth-delicious/Makefile
www/thoth-flickr/Makefile
www/thoth/Makefile

(not in wip, I believe)
---
Makoto Fujiwara
mef%NetBSD.org@localhost


Home | Main Index | Thread Index | Old Index