Re: CVS commit: pkgsrc/sysutils/pfstat

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Sun, May 27, 2012 at 09:17:09PM +0200, John Marino wrote:
 > >  >  Added Files:
 > >  >         pkgsrc/sysutils/pfstat: hacks.mk
 > >  >
 > >  >  Log Message:
 > >  >  sysutils/pfstat: Add DragonFly hack
 > >  >
 > >  >  After spending more time on this this trying to patch it properly than 
 > > I
 > >  >  care to admit, I concede defeat and add a hack.mk for DragonFly.
 > >  >
 > >  >  I'm not exactly sure what the problem is, other than "make" works on 
 > > the
 > >  >  subdir makefile and "bmake" doesn't.  And that's only true if executed
 > >  >  outside of the package -- hardcoding "make" inside the do-build phase
 > >  >  doesn't work.  Weird problem, but the hack works.
 > >
 > >Well yes, "make" inside the do-build phase will get you pkgsrc bmake.
 > >
 > >Given that the offending makefile is completely straightforward and
 > >entirely inoffensive, there must be either a bug in pkgsrc's make
 > >(which ought to be fixed) or in bootstrap-mk-files (ditto).
 > >
 > >Does anything interesting happen if you make build-env and then in the
 > >subshell run make -n by hand in the subdir?
 > 
 > So thanks for telling me about the existence of "bmake build-env".
 > That's useful, I didn't know about it.

It's often quite useful, and not widely known.

 > If I type "make -n" or "bmake -n" in the subdir, the executable is
 > created as would be expected.  Bypassing the wrapper for
 > "/usr/bin/make -n" has the same result.

Hrm. Is the problem that the top-level makefile isn't recursing into
the subdir?

-- 
David A. Holland
dholland%netbsd.org@localhost