Subject: Re: CVS commit: pkgsrc/x11/gnome-themes
To: None <xtraeme@netbsd.org>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: pkgsrc-changes
Date: 10/19/2005 15:30:30
On 10/19/05, Juan Romero Pardines <xtraeme@netbsd.org> wrote:
>
> Module Name:    pkgsrc
> Committed By:   xtraeme
> Date:           Wed Oct 19 09:57:20 UTC 2005
>
> Modified Files:
>         pkgsrc/x11/gnome-themes: Makefile
>
> Log Message:
> Fix the installation. Looks like ${INSTALL} -d did not work, use
> ${INSTALL_DATA_DIR} instead which works fine.

This is not correct; please investigate why ${INSTALL} -d didn't work.
 I agree that
using ${INSTALL} -d as I did is a big hack; I did it because it worked
for me and I
expected it could work in other cases.  As it doesn't always work (as
you've just
found), that hack must be removed and fixed in a correct way.  What
you have done
now is worse, and I doubt it even does the right thing...

The problem is that the package installs files as in:

install -d ... a/b/c /usr/somewhere/targetdir/

and expects install to create the a/b subdirectory inside targetdir
and then copy
the c file to it.  The correct fix is to change all makefiles to first
create the directory
and then copy the file... which is a PITA given the big amount of
files the package
has.  Simpler solutions are welcome...

Will take a look later; I now have to go to class.

--
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/