Subject: Re: CVS commit: pkgsrc/textproc/libxml2
To: Marc Recht <recht@netbsd.org>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: pkgsrc-changes
Date: 02/12/2005 20:04:41
On Sat, 2005-02-12 at 19:08 +0100, Marc Recht wrote:
> > Why?
> 
> Because bsd.pkg.mk is currently "broken". Which breaks at least libxml2 
> and shared-mime-info. A fix for bsd.pkg.mk is attached. (I'm waiting 
> for tv's approval to commit it.)

Hmm I see (haven't checked there was a problem before replying).

> Hmm, the libxml2 makes it pretty clear that he won't take your 
> configure patch

Yes, but he took the patch to only define the catalog macros if they
were not previously defined (so that we'd replace them from the
environment).  This is what the last patch in that bug report did,
and it was commited.

>  -- I don't understand why, though.

I do...  Linux, and its "standards".  You know, other systems cannot
have custom policies on where stuff is placed; if they do, they are
wrong.  (That reminds me of the xdg spec... oh well, better not to get
started on that.)

>  The reason why I'd 
> like to keep the patches is that "-D" is not available with all 
> compilers out there.

Ew, really?  I didn't know that.  But ATM, there are a bunch of packages
in pkgsrc that use it...

Anyway, I'm wondering if some:
	echo "#define XML...." >>${WRKSRC}/config.h
in a post-configure target could do the trick (assuming they are not
further overriden by a call to config.status).

>  (Or we revive your configure patch.)

But that'd mean more local patches, and they could be more complex
than the current ones (not desirable).

Cheers,

-- 
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/