Re: misc/50166

[Robert Millan <rmh%gnu.org@localhost>]

The following reply was made to PR misc/50166; it has been noted by GNATS.

From: Robert Millan <rmh%gnu.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, misc-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, rmh%gnu.org@localhost
Cc: 
Subject: Re: misc/50166
Date: Fri, 11 Sep 2015 01:04:08 +0200

 This is a multi-part message in MIME format.
 --------------010702000706090604010000
 Content-Type: text/plain; charset=windows-1252; format=flowed
 Content-Transfer-Encoding: 7bit
 
 El 31/08/15 a les 01:15, Antti Kantee ha escrit:
 >   > If you want to keep it simple, I could switch it to use uname instead of
 >   > AC_CANONICAL_HOST(). It
 >   > will break cross-compiling but AFAICS the whole purpose of this script
 >   > is to bootstrap make on
 >   > non-NetBSD systems, which is a very native-build oriented end, and I
 >   > doubt cross-compiling was
 >   > ever intended to work here anyways.
 >   >
 >   > Does that sound good?
 >
 >   I assume you mean cross-compiling in the Canadian sense, i.e. building
 >   the tools for another system.  I don't know if that works or is intended
 >   to work.  You can ask tech-toolchain%netbsd.org@localhost and observe the outcry
 >   or lack thereof.
 >
 >   Testing for availability of MAXPATHLEN would be better, though.  I guess
 >   you can just look at some tool using MAXPATHLEN and determine what you
 >   need to include so that you can test if it's available or not.
 
 Hi,
 
 I just realized there's a much simpler way around this, if we want to test for
 MAXPATHLEN as you suggest, autoconf really isn't necessary as it can be done
 directly in C pre-processor.
 
 See attached patch, please let me know what you think.
 
 -- 
 Robert Millan
 
 --------------010702000706090604010000
 Content-Type: text/x-patch;
  name="maxpathlen.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="maxpathlen.diff"
 
 Index: rumpkernel-0~20150715/buildrump.sh/src/usr.bin/make/make.h
 ===================================================================
 --- rumpkernel-0~20150715.orig/buildrump.sh/src/usr.bin/make/make.h	2015-07-23 22:54:05.000000000 +0200
 +++ rumpkernel-0~20150715/buildrump.sh/src/usr.bin/make/make.h	2015-09-05 12:31:02.556270631 +0200
 @@ -503,4 +503,11 @@
  #define MAX(a, b) ((a > b) ? a : b)
  #endif
  
 +/* GNU/Hurd systems lack MAXPATHLEN */
 +#include <limits.h>
 +#ifndef MAXPATHLEN
 +#warning "MAXPATHLEN undefined on this system, forcing an arbitrary limit"
 +#define MAXPATHLEN	4096
 +#endif
 +
  #endif /* _MAKE_H_ */
 
 --------------010702000706090604010000--