Re: kern/48374: Linux API in kern/vfs_xattr.c does not work

[Jarmo Jaakkola <jarmo.jaakkola%roskakori.fi@localhost>]

The following reply was made to PR kern/48374; it has been noted by GNATS.

From: Jarmo Jaakkola <jarmo.jaakkola%roskakori.fi@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/48374: Linux API in kern/vfs_xattr.c does not work
Date: Sat, 9 Nov 2013 15:28:14 +0200

 Heads up!
 
 There's a "break" missing here:
     +          *ns_len = 0;
     +          for (const char *i = key; *i; ++i)
     +                  if ('.' == *i)
     +                          *ns_len = (i + 1) - key;
 
 Assuming we even want to consider any unknown (and possibly missing!)
 prefix as valid and equivalent to "user", this should be:
     +          *ns_len = 0;
     +          for (const char *i = key; *i; ++i)
     +                  if ('.' == *i) {
     +                          *ns_len = (i + 1) - key;
     +                          break;
     +                  }
 
 -- 
 Jarmo Jaakkola