Subject: Re: port-i386/37001 (acpi enabled kernel locks up bringing up fxp0
To: None <joerg@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,>
From: Joerg Sonnenberger <joerg@britannica.bec.de>
List: netbsd-bugs
Date: 11/08/2007 20:15:11
The following reply was made to PR port-i386/37001; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: port-i386/37001 (acpi enabled kernel locks up bringing up fxp0
	NIC)
Date: Thu, 8 Nov 2007 21:00:28 +0100

 --HlL+5n6rz5pIUxbD
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Thu, Nov 08, 2007 at 07:50:03PM +0000, Mathias De Belder wrote:
 >  And here they are, the first one of an ACPI-enabled kernel (with rev.
 >  1.9 of acpi_pci_link.c):
 
 OK, this is sane. It has updated the device for the interrupt it has
 choosen (which was the problem in Stephen's case). But it seems like the
 ACPI SCI really can't be used here. Can you try the attached patch? That
 removes the check for reusing BIOS interrupts, which doesn't make much
 sense IMO.
 
 Joerg
 
 --HlL+5n6rz5pIUxbD
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="acpi_pci_link.c.diff"
 
 Index: acpi_pci_link.c
 ===================================================================
 RCS file: /data/repo/netbsd/src/sys/dev/acpi/acpi_pci_link.c,v
 retrieving revision 1.9
 diff -u -p -r1.9 acpi_pci_link.c
 --- acpi_pci_link.c	7 Nov 2007 15:29:15 -0000	1.9
 +++ acpi_pci_link.c	8 Nov 2007 19:58:18 -0000
 @@ -1024,9 +1024,6 @@ acpi_pci_link_choose_irq(struct acpi_pci
  	best_weight = INT_MAX;
  	for (i = 0; i < link->l_num_irqs; i++) {
  		pos_irq = link->l_irqs[i];
 -		if (pos_irq < NUM_ISA_INTERRUPTS &&
 -		    (pci_link_bios_isa_irqs & 1 << pos_irq) == 0)
 -			continue;
  		pos_weight = pci_link_interrupt_weights[pos_irq];
  		if (pos_weight < best_weight) {
  			best_weight = pos_weight;
 
 --HlL+5n6rz5pIUxbD--