Subject: port-xen/35422: sys/arch/xen has too much duplicated code
To: None <port-xen-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: None <ad@netbsd.org>
List: netbsd-bugs
Date: 01/14/2007 17:35:00
>Number:         35422
>Category:       port-xen
>Synopsis:       sys/arch/xen has too much duplicated code
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    port-xen-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 14 17:35:00 +0000 2007
>Originator:     Andrew Doran
>Release:        NetBSD-current
>Organization:
The NetBSD Project
>Environment:
N/A
>Description:
The xen MD kernel has substantial chunks of code copied from
NetBSD/i386. In some of the modules that I have looked at, the
differences between the xen and i386 versions are trivial.

>How-To-Repeat:
Edit files under arch/i386, break xen, and notice that xen lags
behind i386.

>Fix:
Where the differences are trivial, they should be should be handled
with #ifdef blocks or architecture dependent functions.