>Number:         21111
>Category:       pkg
>Synopsis:       lang/perl5/module.mk has pointless ${DO_NADA}
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 12 08:14:00 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Todd Vierling
>Release:        NetBSD 1.6.1
>Organization:
	DUH.ORG:  Pointing out the obvious since 1994.
>Environment:
>Description:

From lang/perl5/module.mk:

.if defined(PERL5_CONFIGURE) && !empty(PERL5_CONFIGURE:M[yY][eE][sS])
do-configure: perl5-configure
	${_PKG_SILENT}${_PKG_DEBUG}${DO_NADA}
.endif

That ${DO_NADA} command results in the inability for anything .include'ing
this file to define its own "do-configure" rule.  (In general, .include'd
files should simply use a dependency like "do-configure: perl5-configure",
without any commands, to prevent interference with package-supplied rules.)

>How-To-Repeat:
>Fix:

Trivial.

Index: module.mk
===================================================================
RCS file: /cvsroot/pkgsrc/lang/perl5/module.mk,v
retrieving revision 1.8
diff -u -r1.8 module.mk
--- module.mk	2003/03/14 19:37:43	1.8
+++ module.mk	2003/04/12 15:07:20
@@ -47,7 +47,6 @@
 
 .if defined(PERL5_CONFIGURE) && !empty(PERL5_CONFIGURE:M[yY][eE][sS])
 do-configure: perl5-configure
-	${_PKG_SILENT}${_PKG_DEBUG}${DO_NADA}
 .endif
 
 # OTHERLDFLAGS is the hook provided by the perl5 MakeMaker module to allow
>Release-Note:
>Audit-Trail:
>Unformatted: