Re: error building on RHEL5

[Gregory McGarry <g.mcgarry%ieee.org@localhost>]

> On Mon, Sep 01, 2008 at 02:17:50PM +0000, Christos Zoulas wrote:
> > [...]
> > >/dsk/l1/misc/bouyer/current/src/crypto/dist/heimdal/lib/vers/ 
> make-print-version.
> > >c:36: error: expected declaration specifiers or '...' before  
> string constant
> > >/dsk/l1/misc/bouyer/current/src/crypto/dist/heimdal/lib/vers/ 
> make-print-version.
> > >c:36: warning: data definition has no type or storage class
> > >--- includes-libvers ---
> > >*** [make-print-version.lo] Error code 1
> > >
> > >This seems to be the __RCSID macro; any idea how to fix this  
> properly ?
> >
> > I thought I fixed it in current.
>
> Seems not; I double-checked that my source tree is up-to-date (as  
> far as
> cvs can tell).

This looks like a problem after removing a redefinition of __RCSID in  
heimdal's config.h.

The problem is that __RCSID was defined in config.h and was pulled in  
before sys/cdefs.h.  I removed the definition from config.h.

I didn't expect config.h to be used in a host tool too.  I tested on  
OS X, but not on a host which doesn't define __RCSID.

Including sys/cdefs.h early in src/crypto/dist/heimdal/lib/vers/make- 
print-version.c is an option.  Maybe sys/cdefs.h should check if  
__RCSID is already defined?