On Fri, 21 Dec 2007, Joerg Sonnenberger wrote:
> Hi all,
> can someone with viaide(4) test suspend/resume with the attached patch?
> E.g. if reading uncached directories afterwards is still possible?

This is clearly wrong:

+       sc->sc_pm_reg[0] = pci_conf_read(sc->sc_pc, sc->sc_tag,
APO_IDECONF(sc));
+       /* APO_DATATIM(sc) includes APO_UDMA(sc) */
+       sc->sc_pm_reg[0] = pci_conf_read(sc->sc_pc, sc->sc_tag,
APO_DATATIM(sc));
+       /* This two are VIA-only, but should be ignored by other devices. 
*/
+       sc->sc_pm_reg[0] = pci_conf_read(sc->sc_pc, sc->sc_tag,
APO_CTLMISC(sc));
+       sc->sc_pm_reg[0] = pci_conf_read(sc->sc_pc, sc->sc_tag,
APO_MISCTIM(sc));


Cheers,
Jared