Re: MesaLib

[Robert Swindells <rjs%fdy2.co.uk@localhost>]

Taylor R Campbell <campbell+netbsd-tech-x11%mumble.net@localhost> wrote:
> Date: Sun, 09 Jul 2023 21:24:55 +0100
> From: Robert Swindells <rjs%fdy2.co.uk@localhost>
> 
>> I wrote:
>> > I think I have got native MesaLib to build.
>> >
>> > Not tried it out yet and still have to go through the patches in
>> > pkgsrc to see which ones need adding to xsrc.
>> 
>> Tried it out a bit with swrast and an old NVidia system, can try
>> an old AMD card, don't have any Intel systems to try.
>> 
>> glxgears dumps core on old NVidia, doesn't give a useful stack trace.
>
> What stack trace does it give?

Reading symbols from /usr/X11R7/bin/glxgears...
[New process 1375]
[New process 1357]
Core was generated by `glxgears'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f7ff0969435 in ?? ()
[Current thread is 1 (process 1375)]
(gdb) bt
#0  0x00007f7ff0969435 in ?? ()
#1  0x00007f7fffffdfa0 in ?? ()
#2  0x00007f7ff74ce6c0 in ?? ()
#3  0x00007f7ff242881f in ?? ()
#4  0x0000000000000000 in ?? ()

> What seems to be missing from it to make a useful stack trace?

Some idea of where in the source it is crashing would be nice.

>> I have done a build of xsrc MesaLib.old to verify that it still works
>> with my makefile changes.
>> 
>> Am I ok to start committing some of this or do people want to review it
>> first? Would probably do the "old" makefiles first.
>
> Can you please post changes for review first?

<https://ftp.NetBSD.org/pub/NetBSD/misc/rjs/mesa/xorg.diff.gz>
<https://ftp.NetBSD.org/pub/NetBSD/misc/rjs/mesa/MesaLib.diff>

Haven't included the changes to the generated files under
xsrc/external/mit/MesaLib/src, they were just copied from a pkgsrc
build.

There is also a change to add libLLVMAMDGPUDisassembler to the LLVM
runtime.

Index: Makefile
===================================================================
RCS file: /cvsroot/src/external/apache2/llvm/librt/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile    30 May 2021 01:56:58 -0000      1.4
+++ Makefile    9 Jul 2023 21:38:49 -0000
@@ -92,6 +92,7 @@
        libLLVMAMDGPUMCTargetDesc \
        libLLVMAMDGPUTargetInfo \
        libLLVMAMDGPUAsmParser \
+       libLLVMAMDGPUDisassembler \
        libLLVMAMDGPUUtils
 .endif

>> One extra idea is to change everywhere to use the ${OLD_SUFFIX}
>> macro in pathnames that could be "old" or not, this could reduce the
>> work when doing the next upgrade.
>
> That sounds like a good idea.

The diffs include some of this but it isn't finished.