Re: Color support for wsfb/Amiga

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

(CC added to port-luna68k)

On 2022/06/23 1:26, Jukka Andberg wrote:
> The wsfb driver has been working only in monochrome with Amiga
> native graphics mode due to the driver not supporting the Amiga's
> planar video memory format.
>
> But actually I found out that there is a c2p routine [1] included
> with xorg-server that works with shadowfb to convert the pixels into Amiga
> planar format. Enabling it for 8-bit depth looks pretty simple. In
> practice with this we could get 256 color mode on AGA chipsets.
>
> For other depths I didn't have much success so it is still
> monochrome for non-AGA. Performance is also not that great, but it
> is somewhat usable.
>
> Patch attached. Any thoughts before I commit?
>
> --jukka
>
> [1] http://cvsweb.netbsd.org/bsdweb.cgi/xsrc/external/mit/xorg-server/dist/miext/shadow/shafb8.c
>
> P.S. With these wsfb changes the fake 1 bit depth hack can be removed
> from kernel side.

Excellent! It works just fine on my A1200:

https://twitter.com/LabDrunker/status/1539847364730822656

It would be great if we can support color X server on luna68k, which
also has "planer" framebuffer.

A minor concern: With your patch, WSDISPLAYIO_GTYPE ioctl becomes
mandatory even if the driver supports WSDISPLAYIO_GET_FBINFO. But,
we can probably find broken drivers during beta test for netbsd-10,
if such a driver is actually present/used ;)

Thanks,
rin