Re: unaligned access problem in XAA

[Michael <macallan%netbsd.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Nov 30, 2010, at 1:45 AM, Nick Hudson wrote:

> On Monday 29 November 2010 22:58:59 Michael wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Hello,
> >
> > On Nov 29, 2010, at 8:04 AM, Nick Hudson wrote:
> > > On Monday 29 November 2010 13:00:59 Michael wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > > Hello,
> > > >
> > > > On Nov 29, 2010, at 3:30 AM, Nick Hudson wrote:
> > > > > On Monday 29 November 2010 07:40:54 Nick Hudson wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I found an unaligned access that I've fixed with the attached
> > > > > > patch.
> > > > > > Anyone see any problems with it and/or test it on a big endian
> > > > > > platform?
> > > > >
> > > > > Some helpful people (you know who you are) spotted some problems
> > > > > with this
> > > > > version.  Updated version attached.
> > > >
> > > > I'll give it a shot on sparc64 and friends.
> > > > Since I didn't run into it myself, how do you trigger the problem?
> > >
> > > Start X without an xorg.conf on NetBSD/cats with an S3 :)
> >
> > So the S3 driver defaults to 24bit packed pixels? That's weird,  
> > pretty
> > much everything else defaults to 24bit in 32bit pixels. A bug in the
> > S3 driver?
>
> Here's an extract from my Xorg.0.log
>
> [  6373.054] (II) S3VIRGE(0): Creating default Display subsection in  
> Screen
> section
>        "Builtin Default s3virge Screen 0" for depth/fbbpp 24/24
> [  6373.055] (==) S3VIRGE(0): Depth 24, (--) framebuffer bpp 24
> [  6373.056] (==) S3VIRGE(0): RGB weight 888
> [  6373.058] (==) S3VIRGE(0): Default visual is TrueColor
> [  6373.060] (==) S3VIRGE(0): Using HW Cursor
> [  6373.061] (==) S3VIRGE(0): mx_cr3a_fix.

Funny, it does default to 24bit packed.

> > I'm not even sure I have hardware that supports 24bit packed without
> > major contortions.
>
> It works! *shrug*

I'd say go ahead and commit!

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBTPSmpMpnzkX8Yg2nAQKC2gf+It/GZZURsHgcKkB8MvIRvbVrNx9TA7F4
987up0l82jCmNydGPz8sz+g0tQaZ4ZRzxC1YN8I1wmUu2LVbA63u95Kfb1vyJpSV
FfZT7gLy9xF35VpiRfKUmAvegIBkR2mgT2enVv6xd/lMyLvffOImo+X1W+icL0dm
wwFTDm9crAojSrSS0C5a+goOgeLVgVe6PTso5JxMgLyDbjhOWOIAGF6AqO9GizxI
QRwJ9UuLuuE0skR102ifqeLqVDCUvMXzr3Hesfo1PgkAnLwsaEq7OD676g40QZvf
t+/WL0Hf7RsCGM+S8oho23heVepMi933IHKLS0iRJdOw/vLj/DTD5A==
=n7B1
-----END PGP SIGNATURE-----