Re: Optimization for xorg/lib/Makefile

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

On Wed, Nov 05, 2008 at 08:25:00PM +0100, Quentin Garnier wrote:
> On Tue, Nov 04, 2008 at 11:05:12PM +0100, Bernd Ernesti wrote:
> > It turned out that this was a nice idea, but unfortunally not all
> > dependencies were added to the libraries, so this needs a different
> > patch. So we are still at 6 .WAITs :(
> > 
> > Joerg gave me the hint on using -Wl,-z,defs which I added as
> > 'LDFLAGS += -Wl,-z,defs' to /etc/mk.conf to check if all libraries
> > had all there needed libraries recorded and gave up on fixing the
> > following directories:
> >  dri (i just skipped this part)
> 
> They're dlopen'd, but they might still depend on stuff.

They could be linked against libdrm and libOSMesa, but I don't know
if thats enough and needed.

> >  libX11 (no way to get this build done with that check)
> 
> You only need to check the dynamic subdirectory there.  The rest are
> dlopen()'d.

The dynamic one is ok.

> >  libGLU (_Unwind_Resume undefined)
> 
> Isn't that C++ stuff?

Don't know, but it has C++ files so ...

Joerg mentioned something yesterday and that part is in libgcc_s.so

Does that mean it has to be linked against libgcc_s too and how
should the libGLU/Makefile look? It still uses LDADD and DPADD.

> >  libXaw7 (xawPrintShellWidgetClass undefined)
> 
> Maybe we left a source file out.

That part was fixed with the -DXAW7 which you added.

> [...]
> > Index: libOSMesa/Makefile
> > ===================================================================
> > RCS file: /cvsroot/src/external/mit/xorg/lib/libOSMesa/Makefile,v
> > retrieving revision 1.2
> > diff -b -u -r1.2 Makefile
> > --- libOSMesa/Makefile      26 Sep 2008 07:15:53 -0000      1.2
> > +++ libOSMesa/Makefile      4 Nov 2008 22:02:28 -0000
> > @@ -125,5 +125,8 @@
> >  CPPFLAGS+= -I${X11SRCDIR.MesaLib}/src/mesa/${_path_}
> >  .endfor
> >  
> > +LDADD+=            -lm 
> > +DPADD+=            ${LIBM}
> > +
> >  .include <bsd.x11.mk>
> >  .include <bsd.lib.mk>
> 
> Why not LIBDPLIBS here?

Because I used libGLU/Makefile as an example.

Ok, I changed it to use LIBDPLIBS.

Bernd