Subject: Re: CVS commit: xsrc/xfree/xc/programs/Xserver/hw/netbsd/hpc
To: None <tech-x11@netbsd.org>
From: Valeriy E. Ushakov <uwe@ptc.spbu.ru>
List: tech-x11
Date: 01/03/2004 07:24:59
On Sat, Jan 03, 2004 at 04:06:04 +0000, Valeriy E. Ushakov wrote:

> Module Name:	xsrc
> Committed By:	uwe
> Date:		Sat Jan  3 04:06:04 UTC 2004
> 
> Modified Files:
> 	xsrc/xfree/xc/programs/Xserver/hw/netbsd/hpc: hpcFB.c
> 
> Log Message:
> Spell FORCE_SEPARATE_PRIVATE correctly.

Looking at the logic makes me wonder if Xhpc still works on hpcmips.
as this spelling error should have caused CFB_NEED_SCREEN_PRIVATE to
be undefined.

Also, I don't feel good about this redefinition trick, b/c it can
potentially make hpcFB.c and cfb have different ideas about
CFB_NEED_SCREEN_PRIVATE.  If that's ok, hpcFB.c at least deserves an
explanatory comment to that effect.

PS: Thanks for committing Xhpc stuff.

SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://www.ptc.spbu.ru/~uwe/            |       Ist zu Grunde gehen