Subject: Re: WORLDOPTS = -k considered harmful
To: None <tech-x11@netbsd.org>
From: Matthias Scheler <tron@zhadum.de>
List: tech-x11
Date: 07/30/2002 20:41:18
In article <16086.1027652893@eterna.com.au>,
	matthew green <mrg@eterna.com.au> writes:
> both xsrc/xc/Makefile and xsrc/xfree/xc/Makefile have this:
> 
> 	WORLDOPTS = -k
> 	[ ... ]
> 		$(MAKE_CMD) $(MFLAGS) $(WORLDOPTS) World
> 
> 
> so that make World is always given "-k".  this means that build failures
> are ignored and you think you got a successful build until you notice
> that certain things are missing.

I've also bitten by this several times. I think this is intended to continue
a build running overnight. The errors are nevertheless detected during
"make install".

> unless someone comes up with a really good reason not to, i'm going to
> change both Makefile's to set WORLDOPTS to "" (after i have tested that
> doing so does not actually break anything.)

Please go ahead.

	Kind regards

-- 
Matthias Scheler                                  http://scheler.de/~matthias/