On Wed, 23 Dec 2020, Martin Husemann wrote:
On Wed, Dec 23, 2020 at 06:56:31AM +0000, RVP wrote:/usr/sbin/wsmoused has been non-working since slightly before 9.1 was released. Specifically, any button click or release generates:Can you narrow down the pullup that broke it?
I was mis-remembering. I just tried out 9.0 and it is broken
there too. This change is what caused the breakage in
wsmoused(8):
cvs rdiff -r 1.13 -r 1.14 src/sys/dev/wscons/wsdisplay_vcons.c
This test in function vcons_getwschar():
if ((wsc->row >= 0) && (wsc->row < ri->ri_rows) && (wsc->col >= 0) &&
(wsc->col < ri->ri_cols)) {
I'm surprised that nobody's noticed this breakage since Aug 2007.
Is console + wsmoused so little used? ;)
-RVP