Re: new code / small geolocalisation service

[David CARLIER <devnexen%gmail.com@localhost>]

Thanks for looking at this.


On 3 November 2015 at 23:42, Greg Troxel <gdt%ir.bbn.com@localhost> wrote:


For new functionality, a key question is if it belongs in the base
system or in pkgsrc.  Generally, there is a high bar for base in terms
of being useful to many, since the maintenance cost and increased size
of the codebase is borne by all.   Another consideration is portability;
pkgsrc can wrap portable programs for multiple operating systems, vs
something specifically for NetBSD.  Another is that base system
components cannot depend on things not in the base.


In fact originally I wrote it for OpenBSD and thought that unix socket could be used by relayd, httpd and so on ...
making this service available for every external server. I rewrote it as some functions like setresuid were not available (until I looked at kern_prot and realised in fact they were, internally ...) making in more portable as a result so ...


 
It looks like what you've done is provided an import of geoip, plus the
daemon.  GeoIP is already in pkgsrc.  So what's really new is the
daemon, and that seems like it is or could be portable.   I wonder if
you have considered releasing the daemon and whatever's necessary to
access it (how to use the daemon was not immediately apparentl from a
quick skim of man pages) as a package, which could then be put into
pkgsrc.



... yes and indeed geoip is already in base so with your points I m in between the two stances. In another hand I had in mind other backends like ip2location which are not packaged.