tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: reallocarr(3) cleanup



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 17.03.2015 23:56, Kamil Rytarowski wrote:
> Hello,
> 
> I'm attaching a patch with reallocarr{.ay}(3) cleanup: - merge
> reallocarr.3 to malloc.3 for consistency, - make the reallocarr(3)
> documentation more detailed, - write history in malloc.3 of
> function allocations, - add in malloc.3 warning about possible
> overflows, - add erallocarr(3) to libutil, - add missing Id tag to
> reallocarray.c, - sync reallocarr prototype with documentation (num
> -> number), - note that reallocarr first appeared in .Nx 8 not 7
> (am I right about it?).
> 
> Please review the English correctness.
> 
> src/lib/libc/stdlib/reallocarray.3 is without licensing notes!
> please add it.
> 
> CC: authors of the new function.
> 
> Thank you for your time!
> 

I noticed that I forgot to attach the patch..
https://github.com/krytarowski/netbsd/commit/75c12bd4e1458485e585fab3980
f250fdb80329b

I'm planning to commit on Monday (13 Jul) from it the following changes:
- - add erallocarr(3) to libutil,
- - add missing Id tag to reallocarray.c,
- - sync reallocarr prototype with documentation (num -> number),
- - reorder memcpy(3) and save errno -- for safety as memcpy(3) might
change it.

I will leave man pages for now.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVoRehAAoJEEuzCOmwLnZsP7wP/3Gzjyiq3Fyu6ltQCnRKYKXT
upmpcH3hYdLXwRisU/xsxMtz1vsx6EkFDWb09WDxY6k/S2lFTf+ulOcTiTWEWcyY
uIKpy0wWigr2sYhhMB9vcEMxq+oVuFyxMk62Gbb26rqhRm9T8J43w/BlzIHTJM9I
q9TcKbUXTc4nvz5ooaSDw/3l21x4n+K3hxrQMMzXApdJ7cVvE+ZHbgigmktVWNzN
oWcf1ixvLH3eiq+3rIGsY9sNsd1Sh1ujkFkq1YcsUg0lEn56aX1HmR3t1xwGbse+
V7iWcotqq06/zgh1srjQViaAfBWtHwdGGPrcpRxM4at+X4kv9+Te/JAHhfztv4Lv
0t6z/aWXup7j6wJ2kTKjCq9j2IV9xZ9skcjqon6D/FByj17jsWiqSn8ZjFZ7gdql
MCDLidgEuMFy6jTCBG4qwodbmnQpAXVMaXMBWbgLo+g3aIKpQ3P3A88xspAxiJlS
Ux4rsUQEQIwaafSZNpRwjvYb+FavNoAyRQraFuH0DiDdh7d6lpDaBkCVHrO+nVMF
ikfk2IM4nQpqcrUMOdND8rW7x3qS3egmc/lxQEKcXv+jVtE4OSJNg2m/q3oqtTpB
0sqjlRTXcsG4P2TXVCnLb91CSIhokQiUINk2BzCJEBqP2GMxslRUJBsUImLJ9duH
gi3pl+264AsZPNxM3aZA
=q+l8
-----END PGP SIGNATURE-----


Home | Main Index | Thread Index | Old Index