tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/44246: enhance mv to work better with xargs

On Sat, Jan 12, 2013 at 08:21:59PM -0600, Eric Schnoebelen wrote:
 > -    for (rval = 0; --argc; ++argv) {
 > +    for (rval = 0; argc--; argv++) {

Can you change that to a normal for (i=1; i<argc; i++) type of loop?
Custom loop logic always worries passersby... and this particular diff
really looks wrong even though I'm pretty sure it isn't.

Other than that, seems like a fine idea to me.

David A. Holland

Home | Main Index | Thread Index | Old Index