tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Limiting rpc.lockd to IPv4 only

On Sun, 12 Aug 2012, Edgar Fuß wrote:

+       proto = 4;
I find it confusing for that to mean IPv6.

I suppose there is prior usage for the v4->2, v6->4 mapping, but I feel that
line needs a comment to the effect that proto = 4 selects IPv6.

It's actually used as the maxindex into the transports[] array. The array has two entries for IPv4 and two for IPv6.

I'd be happy to add a comment. Or maybe just change the variable name (or re-work to use existing variable).

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index