tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Adding missing __printflike attributions

On 3/4/12 2:52 PM, Alan Barrett wrote:
On Sun, 04 Mar 2012, Julio Merino wrote:
For files within atf, please do:


Ow! Why yet another way to say the same thing?

Because attributes are not portable across compilers and atf is
supposed to work on different platforms?

Portability is one of the reasons why we use __printflike instead of
__attribute__((__format__(whatever))). Readability is another reason.

You can define __printflike differently for different compilers just as
easily as you can define ATF_DEFS_ATTRIBUTE_FORMAT_PRINTF differently
for different compilers, so ATF_DEFS_ATTRIBUTE_FORMAT_PRINTF·does not
seem to have any advantage.

Except that the code lives in external/bsd/atf/ and is shipped in other systems that do not have __printflike.

__printflike is a NetBSD-ism, right? If so, why do you think NetBSD is more important than any other system and thus __printflike has to be used?

Home | Main Index | Thread Index | Old Index