On Tue, Aug 26, 2008 at 02:26:13PM +0200, Joerg Sonnenberger wrote:
| Hi all,
| a lot of the older NetBSD source files start with
|
| #include <sys/cdefs.h>
| #if defined(LIBC_SCCS) && !defined(lint)
| #if 0
| static char sccsid[] = "@(#)abort.c 8.1 (Berkeley) 6/4/93";
| #else
| __RCSID("$NetBSD: abort.c,v 1.12 2003/08/07 16:43:37 agc Exp $");
| #endif
| #endif /* LIBC_SCCS and not lint */
|
| for libc and without the defined(LIBC_SCCS) conditional for normal
| sources.
|
| I think this is a lot of redundant noise and before copying it yet again
| to different places, I'd like to be able to clean this up for the
| involved sources.
|
| [...]
|
| With the above suggestions, it would become:
| #include <sys/cdefs.h>
| __SCCSID("@(#)abort.c 8.1 (Berkeley) 6/4/93");
| __RCSID("$NetBSD: abort.c,v 1.12 2003/08/07 16:43:37 agc Exp $");
|
| or just
| #include <sys/cdefs.h>
| __RCSID("$NetBSD: abort.c,v 1.12 2003/08/07 16:43:37 agc Exp $");
I think we should move to the latter -- __RCSID only, no #ifndef lint.
The SCCSIDs are just extra noise and don't serve to differentiate
source versions in the way that __RCSID does (although not for the
header files that the source files include)
Luke.
Attachment:
pgpVfA9GPbz9k.pgp
Description: PGP signature