Subject: Re: soc zfs: namespace collision between proplib and compat code
To: Oliver Gould <firstname.lastname@example.org>
From: Jason Thorpe <email@example.com>
Date: 08/15/2007 14:46:03
On Aug 15, 2007, at 1:14 PM, Oliver Gould wrote:
> Otherwise, it seems (to me) like a good idea to change proplib's
> boolean_t to e.g. prop_boolean_t -- or, better yet, bool_t. While
> there's probably a good reason why proplib doesn't use bool_t already,
> the namespace collision seems likely to be problematic outside of ZFS,
> Or, if code in the NetBSD source tree is actually going to continue
> using boolean_t, perhaps its definition could be moved somewhere more
> common to other code?
> My dirty hack for now is to include <prop/prop_object.h> from the
> sys/types.h, but I don't like that as a general solution. Am I
> otherwise stuck changing all of the Solaris code away from boolean_t?
> Any other suggestions?
I'll check in a change to proplib soon that moves proplib over to
bool. I have the changes in my tree, but haven't had time to finalize
it and check it in.
> - Oliver