Subject: Re: ls(1) support for multibyte chars
To: SODA Noriyuki <firstname.lastname@example.org>
From: Thomas Klausner <wiz@NetBSD.org>
Date: 06/05/2007 19:48:30
On Thu, May 31, 2007 at 03:39:13AM +0900, SODA Noriyuki wrote:
> >>>>> On Tue, 29 May 2007 18:38:22 +0200,
> Thomas Klausner <wiz@NetBSD.org> said:
> > In a private discussion, SODA Noriyuki provided the attached patch for
> > adding multibyte support to ls(1).
> > Is it ok to commit?
> > + if (span > MB_CUR_MAX)
> > + span = MB_CUR_MAX;
> It seems to be better to make the above part commented out by "#if 0".
> Because if there are reduandant escape sequences which exceeds 32 bytes,
> our current implementation doesn't display the pathname correctly with
Ok, I committed it with that additional change.
Thanks you for the patch!