Subject: Re: syslog_r (Re: CVS commit: src/lib/libc)
To: der Mouse <mouse@Rodents.Montreal.QC.CA>
From: SODA Noriyuki <email@example.com>
Date: 10/26/2006 17:34:08
>>>>> On Thu, 26 Oct 2006 03:52:41 -0400 (EDT),
der Mouse <mouse@Rodents.Montreal.QC.CA> said:
>> The OpenBSD documentation is wrong.
>> For example, the snprintf() function indirectly calls __dtoa() via
>> following path:
>> snprintf() -> vfprintf() -> cvt() -> __dtoa()
>> And the __dtoa() implemenation modifies lots of static data [...]
> Perhaps snprintf *can* end up calling __dtoa. But does it actually do
> so when called the way syslog_r calls it? (This is an honest question;
> I don't know the answer, but it seems at least plausible that syslog_r
> may take care to call snprintf only in ways that end up being
OpenBSD man page doesn't say that floating point format shoundn't be
used in signal handlers, and their syslog_r() implementation doesn't
reject floating point format. So, it doesn't take care of it at all.
Also, as yamt said, the vfprintf() function is calling locale stuff
(e.g. mbrtowc()) in its main loop to parse the format string. And
such stuff isn't documented as async-singal-safe either.