Subject: Re: isspace and compiler warnings
To: Martin Husemann <martin@duskware.de>
From: Thomas Dickey <dickey@radix.net>
List: tech-userlevel
Date: 10/18/2006 08:52:11
--sm4nu43k4a2Rpi4c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 18, 2006 at 02:47:07PM +0200, Martin Husemann wrote:
> On Wed, Oct 18, 2006 at 08:42:57AM -0400, Greg Troxel wrote:
> > So, is the ufraw code above wrong?=20
>=20
> Yes.
>=20
> > If so, should I cast to int?
>=20
> In this context, since it can not be EOF, just cast it to an unsigned cha=
r.

that's more portable, since some architectures have signed char's.
(agreeing that the code must also ensure that the value is not EOF).

--=20
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net

--sm4nu43k4a2Rpi4c
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (SunOS)
Comment: For info see http://www.gnupg.org

iD8DBQFFNiNutIqByHxlDocRAoz0AKCsbvKDz883yusXHJ4oEva/RizjrACeLUOf
c+5GpYYhGkhrPnKlPk1RPlg=
=XBCO
-----END PGP SIGNATURE-----

--sm4nu43k4a2Rpi4c--