Subject: Re: rcp patch
To: None <>
From: Thor Lancelot Simon <>
List: tech-userlevel
Date: 06/08/2006 17:08:29
On Thu, Jun 08, 2006 at 01:01:23PM -0700, wrote:
> heres a little patch i wrote to clean up some of the rcp code.

I don't really see how this "cleans up" the code (though it could
definitely use some cleanup).  All it seems to do is rename some variables
so that they have underscores in their names, and replace a lot of error
test conditionals of the form:

return = function(arg);
if (return == NULL) {

with the form:

if ((return = function(arg)) == NULL) {

Which I actually find considerably harder to read.

Am I missing something?