Subject: Next fallout of the inline changes (net/pfil.h)
To: Perry E. Metzger <>
From: Bernd Ernesti <>
List: tech-userlevel
Date: 01/01/2006 11:49:55
On Sat, Dec 24, 2005 at 08:45:10PM +0000, Perry E. Metzger wrote:
> Module Name:	src
> Committed By:	perry
> Date:		Sat Dec 24 20:45:10 UTC 2005
> Modified Files:
> 	src/sys/net: bpf.c if_bridge.c pfil.h rtsock.c
> Log Message:
> Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.
> To generate a diff of this commit:
> cvs rdiff -r1.25 -r1.26 src/sys/net/pfil.h

This breaks a non NetBSD build for XFree86 in a some places.
Here is one example, which breaks the compile of the Xserver:

gcc -c -O2 -fno-strict-aliasing -ansi -Dasm=3D__asm -Wall -Wpointer-arith -=
Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wredundant-=
decls -Wnested-externs -Wundef -fno-merge-constants -I. -I../../../programs=
/Xserver/os -I../../../programs/Xserver/include -I../../../programs/Xserver=
/Xext -I../../../programs/Xserver/render -I../../../lib/Xau -I../../../prog=
rams/Xserver/lbx -I../../../exports/include -DCSRG_BASED -DSHAPE -DXINPUT -=
RIV -DSINGLEDEPTH -DXFreeXDGA -DXvExtension -DXFree86LOADER -DXFree86Server=
In file included from /usr/include/net/if.h:86,
                 from access.c:115:
/usr/include/net/pfil.h:101: error: syntax error before "struct"
access.c: In function `ResetHosts':
access.c:1132: warning: subscript has type `char'
*** Error code 1

make: stopped in /home/work/xfree/xc/programs/Xserver/os
*** Error code 1

Another example is one is auth.c in xdm.

Hmm, <net/pfil.h> is protected by an '#if defined(_NETBSD_SOURCE)'.
Michael van Elst suggested to add an test for '&& !defined(__STRICT_ANSI__)'
to <sys/featuretest.h>.

Klaus, what do you think about that idea?

For the moment I would suggest to backout the pfil.h change.