On Sat, Dec 24, 2005 at 08:45:10PM +0000, Perry E. Metzger wrote:
>=20
> Module Name:	src
> Committed By:	perry
> Date:		Sat Dec 24 20:45:10 UTC 2005
>=20
> Modified Files:
[..]
> 	src/sys/net: bpf.c if_bridge.c pfil.h rtsock.c
[..]
>=20
> Log Message:
> Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.
>=20
>=20
> To generate a diff of this commit:
[..]
> cvs rdiff -r1.25 -r1.26 src/sys/net/pfil.h
[..]

This breaks a non NetBSD build for XFree86 in a some places.
Here is one example, which breaks the compile of the Xserver:

gcc -c -O2 -fno-strict-aliasing -ansi -Dasm=3D__asm -Wall -Wpointer-arith -=
Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wredundant-=
decls -Wnested-externs -Wundef -fno-merge-constants -I. -I../../../programs=
/Xserver/os -I../../../programs/Xserver/include -I../../../programs/Xserver=
/Xext -I../../../programs/Xserver/render -I../../../lib/Xau -I../../../prog=
rams/Xserver/lbx -I../../../exports/include -DCSRG_BASED -DSHAPE -DXINPUT -=
DXKB -DLBX -DXAPPGROUP -DXCSECURITY -DTOGCUP -DXF86BIGFONT -DDPMSExtension =
-DPIXPRIV -DPANORAMIX -DRENDER -DRANDR -DGCCUSESGAS -DAVOID_GLYPHBLT -DPIXP=
RIV -DSINGLEDEPTH -DXFreeXDGA -DXvExtension -DXFree86LOADER -DXFree86Server=
 -DXF86VIDMODE -DXvMCExtension -DSMART_SCHEDULE -DBUILDDEBUG -DXResExtensio=
n -DX_BYTE_ORDER=3DX_LITTLE_ENDIAN -DNDEBUG -DFUNCPROTO=3D15 -DNARROWPROTO =
-DXSERV_t -DTRANS_SERVER -DTCPCONN -DUNIXCONN -DHAS_STICKY_DIR_BIT -DHAS_FC=
HOWN -DIPv6 -DHASXDMAUTH -DDDXOSINIT -DSERVER_LOCK -DDDXOSFATALERROR -DDDXO=
SVERRORF -DBUILTIN_RGB -DHAS_ASPRINTF  -DXDMCP -DXDMCP_NO_IPV6 -DBSD44SOCKE=
TS -DHAS_GETIFADDRS access.c
In file included from /usr/include/net/if.h:86,
                 from access.c:115:
/usr/include/net/pfil.h:101: error: syntax error before "struct"
access.c: In function `ResetHosts':
access.c:1132: warning: subscript has type `char'
*** Error code 1

Stop.
make: stopped in /home/work/xfree/xc/programs/Xserver/os
*** Error code 1

Another example is one is auth.c in xdm.

Hmm, <net/pfil.h> is protected by an '#if defined(_NETBSD_SOURCE)'.
Michael van Elst suggested to add an test for '&& !defined(__STRICT_ANSI__)'
to <sys/featuretest.h>.

Klaus, what do you think about that idea?

For the moment I would suggest to backout the pfil.h change.

Bernd