Subject: Re: RFC on two possible ftpd changes
To: Brian Ginsbach <ginsbach@NetBSD.org>
From: Luke Mewburn <lukem@NetBSD.org>
Date: 08/24/2005 11:50:10
Content-Type: text/plain; charset=us-ascii
On Tue, Aug 16, 2005 at 06:17:27PM +0000, Brian Ginsbach wrote:
| I've got a couple changes to ftpd that I'm wondering if I should
| commit. I've discovered a performance issue, at least on some
| systems when using tnftpd, with puts to the server. The performance
| is poor because the buffer used by the server is too small.
| I've coded a patch to make receive_data() work very similar to
| send_data_with_read(). This patch makes the readsize configuration
| parameter apply to reads from the disk (sending data to a client)
| and reads from the network (receiving data from a client). If the
| readsize isn't set, again similar to send_data_with_read(), the
| filesystem block size is used. I kept BUFSIZ as a failsafe incase
| the fstat(2) failed.
| Also for some additional performance tuning ability I added an
| additional configuration parameter: recvbufsize. This is very
| similar to the current sendbufsize option.
This might also make it easier to implement SSL support in the future.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (NetBSD)
-----END PGP SIGNATURE-----