Subject: Re: scan_ffs from OpenBSD ported and improved.
To: Julio M. Merino Vidal <firstname.lastname@example.org>
From: Juan RP <email@example.com>
Date: 06/11/2005 19:25:54
On Tue, 07 Jun 2005 10:37:41 +0000
"Julio M. Merino Vidal" <firstname.lastname@example.org> wrote:
> You still have formatting problems WRT style.
> There are several commas without spaces after them, and I'm sure that's
> not on purpose. Also, second-level indents (i.e., line continuations)
> should be four spaces, not a tab. See style again.
> Local variable declarations should be sorted in a special way, and be
> kept together. This is also documented in style, and there is a
> rationale about it too. Please read that document.
> I haven't checked the manual page extensively, but:
> - The AUTHORS section should be improved; use the An and Aq macros.
> - Operating system names are written with Ox and Nx, among others.
> - Apply the "New sentence, new line" policy.
> - Sort command line options alphabetically.
> At last, you'd make the usage function clearer by using a single printf.
> (At the moment, it looks like as if it were two lines, while it's just
Ok, I'll fix that soon.