Subject: Re: scan_ffs from OpenBSD ported and improved.
To: Julio M. Merino Vidal <firstname.lastname@example.org>
From: Simon Burge <email@example.com>
Date: 06/07/2005 10:09:03
"Julio M. Merino Vidal" wrote:
> >From a very quick review, I see:
> - Auxiliary functions are not static.
Why do they need to be static? While some of our source tree does this,
it's not the most common practice.
> - Functions that return values which are discarded should be prefixed
> with (void). I.e., (void)printf("blah");
I've always thought that "(void)printf(..." was overkill. In our source
tree, a quick grep shows 71520 printf's without void and 2203 with void.
Simon Burge <firstname.lastname@example.org>
NetBSD Support and Service: http://www.wasabisystems.com/