Subject: Re: scan_ffs from OpenBSD ported and improved.
To: None <tech-userlevel@NetBSD.org>
From: der Mouse <mouse@Rodents.Montreal.QC.CA>
List: tech-userlevel
Date: 06/06/2005 23:56:55
>>> In calls to printf(3), explicitly cast the PRIu64 arguments to
>>> uint64_t.  Just for portability.  Or find someone who guarantees
>>> that daddr_t will always be (and stay) equivalent to uint64_t.
>> I thought PRI* definitions were already portable?

> The only use of PRIu64 is as a format specification for passing a
> uint64_t to the printf family of functions.

> It has nothing to do with other data types, especially not daddr_t.

And, furthermore, casting to uint64_t and using PRIu64 assumes that a
daddr_t will never be bigger than 64 bits.  It seems to me you should
be using PRIuMAX and uintmax_t....

/~\ The ASCII				der Mouse
\ / Ribbon Campaign
 X  Against HTML	       mouse@rodents.montreal.qc.ca
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B