Subject: Re: chmod patch
To: None <email@example.com>
From: Christos Zoulas <firstname.lastname@example.org>
Date: 05/17/2005 14:33:55
In article <20050517183626.GA468@anarion>,
Liam J. Foy <email@example.com> wrote:
> Could you guys look at the following patch:
>- setmode(3) can return NULL due to malloc failing. However,
> if malloc does fail an incorrect error message would be
> printed. You can resolve this by checking errno.
Actually someone will need to fix the source for setmode in order
for your patch to work. There are other calls that can set errno
(strtol() for example), so your patch is incorrect. You should
file a PR about fixing error checking and documentation in setmode.