Subject: Re: wall and no tty
To: Christos Zoulas <christos@zoulas.com>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: tech-userlevel
Date: 10/27/2004 22:20:59
On Wed, Oct 27, 2004 at 01:29:25PM -0400, Christos Zoulas wrote:
> On Oct 27,  5:47pm, bouyer@antioche.lip6.fr (Manuel Bouyer) wrote:
> -- Subject: Re: wall and no tty
> 
> | On Wed, Oct 27, 2004 at 10:05:12AM -0400, Christos Zoulas wrote:
> | > | and never call check_sender() ?
> | > | But then this would revert wall.c 1.23, which was the fix for PR/7713.
> | > 
> | > No, just skip the check in check_sender if we cannot find the tty of the user.
> | > I.e. s/if (myuid == 0)//
> | 
> | Ha, OK. Yes, this would be OK for wall, but write() uses check_sender() too,
> | and it doesn't deal with check_sender() returning NULL (but should be as simple
> | as if (mytty == NULL) errx("...");)
> 
> You are right, I'll come up with a fix.

Ok, this looks good. Thanks.

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--