Subject: Re: inb, outb, i386_set_ioperm and such
To: Bruce J.A. Nourish <netbsd@bjan.freeshell.org>
From: Dave Huang <khym@azeotrope.org>
List: tech-userlevel
Date: 03/28/2004 16:20:54
On Sun, Mar 28, 2004 at 08:25:06AM -0700, Bruce J.A. Nourish wrote:
> * Given "from" and "num", two integers that describe a range of ports
>   to open up for inb/outb access, does the following code set up the
>   iomap correctly?
> 
>   for (i = 0; i < num; ++i)
>        iomap[(from + num) / 32] |= 1 << (from + num) % 32;

Shouldn't "i" be in that loop somewhere? s/from + num/from + i/g
-- 
Name: Dave Huang         |  Mammal, mammal / their names are called /
INet: khym@azeotrope.org |  they raise a paw / the bat, the cat /
FurryMUCK: Dahan         |  dolphin and dog / koala bear and hog -- TMBG
Dahan: Hani G Y+C 28 Y++ L+++ W- C++ T++ A+ E+ S++ V++ F- Q+++ P+ B+ PA+ PL++