--bg08WKrSYDhXBjb5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 31, 2004 at 01:56:27PM +1100, Simon Burge wrote:
> Christos Zoulas wrote:
>=20
> > Looks nice! A few comments:
> >=20
> > [ ... ]
> > 6. All functions in there and globals should be static.
>=20
> Do we really need to do this?  There is only one .c file in this
> program, and it's certainly not common practice elsewhere in our
> source tree for single source file programs.

Not common practice? it took me about one minute to come up with this list
of single source file programs. Sure, they may be less complex than identd,
but identd is not very complex either. I think a single-source-file identd
is fine, and if it gives us functionality our existing identd doesn't have,
what is so wrong with it being one source file? I've wanted the
user-settable reply feature for a while, and have patched it into our
existing identd before. It wasn't a complicated change. While I haven't
examined the submitted identd source, I don't see any reason it should be
scorned simply because it is contained in one source file.

bin/cat/cat.c
bin/chio/chio.c
bin/chmod/chmod.c
bin/df/df.c
bin/domainname/domainname.c
bin/echo/echo.c
bin/hostname/hostname.c
bin/kill/kill.c
bin/mkdir/mkdir.c
bin/mt/mt.c
bin/mv/mv.c
bin/rm/rm.c
bin/rmdir/rmdir.c
bin/sync/sync.c
bin/test/test.c
usr.bin/apply/apply.c
usr.bin/apropos/apropos.c
usr.bin/asa/asa.c
usr.bin/basename/basename.c
usr.bin/bdes/bdes.c
usr.bin/biff/biff.c
usr.bin/cal/cal.c
usr.bin/calendar/calendar.c
usr.bin/cap_mkdb/cap_mkdb.c
usr.bin/cdplay/cdplay.c
usr.bin/checknr/checknr.c
usr.bin/chflags/chflags.c
usr.bin/column/column.c

=2E.. shall I go on? ...

-Sean

--
/~\ The ASCII
\ / Ribbon Campaign                   Sean Davis
 X  Against HTML                       aka dive
/ \ Email!

--bg08WKrSYDhXBjb5
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAGzDecMEZWGhfx9kRAix3AKCTQ4htqlMnDPrbkW9JRyPqEvmwswCgvAKv
Ir+lbPjXVobe/krXAQW6O5A=
=QUKX
-----END PGP SIGNATURE-----

--bg08WKrSYDhXBjb5--