Subject: Re: try again: unsetenv memory leak fix
To: Masaru OKI <email@example.com>
From: Brian Ginsbach <firstname.lastname@example.org>
Date: 07/11/2003 16:00:08
* Masaru OKI <email@example.com> [2003/06/29 14:26]:
> I've fixed a bug pointed out by david. thanks!
> please review it.
* David Laight <firstname.lastname@example.org> [2003/06/28 03:23]:
> There are several bugs lurking still:
> 1) unsetenv will dump if the env hasn't been expanded.
> 2) setenv will dump if an item is overwritten with a longer string
> and the env hasn't been expanded.
> 3) you should probably check that the saved pointer matches the env one
> before freeing it.
I think you've only fixed 1 and 3.
Brian Ginsbach Cray Inc.