Subject: Re: review wanted: -p port for rsh / rlogin
To: Hubert Feyrer <hubert.feyrer@informatik.fh-regensburg.de>
From: Matt Thomas <matt@3am-software.com>
List: tech-userlevel
Date: 03/29/2003 09:53:43
At 09:28 PM 3/28/2003, you wrote:
>+ if (sp == NULL) { /* number given, no name */
>+ sp = malloc(sizeof(*sp));
>+ memset(sp, 0, sizeof(*sp));
>+ sp->s_name = service;
>+ sp->s_port = atoi(service);
If service isn't a number, then you'll get the wrong result.
Maybe use strtoul since ports are negative. Also make sure
the result isn't 0 or > 65535.
--
Matt Thomas Internet: matt@3am-software.com
3am Software Foundry WWW URL: http://www.3am-software.com/bio/matt/
Cupertino, CA Disclaimer: I avow all knowledge of this message