Subject: Re: chksniff
To: <>
From: Ignatios Souvatzis <is@netbsd.org>
List: tech-userlevel
Date: 03/22/2003 21:27:17
--qcHopEYAB45HaUaB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

another nit:

> 	if ((fd = socket(AF_INET, SOCK_STREAM, 0)) == -1) {	/* We open the socket

That's wrong. In our OS, AF_foo happens to be == PF_foo, but you may not
assume that for portable software, and socket() takes a protocol family
(PF_foo).

Regards,
	-is

--qcHopEYAB45HaUaB
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (NetBSD)

iD8DBQE+fMcjPCRcZ/VMtk4RAuKWAJwOdQbiLTqOQYtL6SOOtaXBtwxjIACfb5x7
hnmojFmKvHSwW/vAJrN7yo0=
=Glh2
-----END PGP SIGNATURE-----

--qcHopEYAB45HaUaB--