On Tue, Mar 05, 2002 at 12:19:08AM +1100, Luke Mewburn wrote:
> On Mon, Mar 04, 2002 at 12:53:31PM +0000, Patrick Welche wrote:
>   | make release still won't work on i386 distrib floppies if RELEASEDIR is set
>   | in /etc/mk.conf rather than in the environment. lukem already fixed one
>   | instance of this in kernel-ramdisk/Makefile by moving bsd.own.mk further up
>   | the Makefile. The problem still exists essentially for the other Makefiles
>   | involving check_RELEASEDIR target. I wonder if it wouldn't be better to
>   | .include <bsd.own.mk> in src/distrib/Makefile.inc where the target
>   | check_RELEASEDIR is defined, rather than fiddle with each Makefile which
>   | uses it. What is common practice?
> 
> We could just move the targets to bsd.own.mk (or somewhere else in share/mk)
> instead.

Yes.. It becomes a matter of esthetics :) One argument for leaving the
targets where they are is that I don't see why parts outside of src/distrib
would want to check for RELEASEDIR.. If there are some other cases, then
yes, why not..

Cheers,

Patrick