Subject: Re: a few minor cleanups to src/share/misc/style
To: Chris G. Demetriou <email@example.com>
From: Alistair Crooks <firstname.lastname@example.org>
Date: 03/22/2001 08:49:06
On Wed, Mar 21, 2001 at 05:53:29PM -0800, Chris G. Demetriou wrote:
> Here are a few minor cleanups to src/share/misc/style:
> * Fix a malformed pair of block comments (lack of space between them),
> in the way that I think is appropriate: combining them into one.
Not a biggy.
> * convert exit codes to use EXIT_SUCCESS and EXIT_FAILURE rather than
> 0 and 1. (following c89.)
> * explicitly mention that exits from main() should be done via exit(),
> rather than return. This was already demonstrated implicitly by the
> sample code, but probably bears explicit mention.
In this case, the lint libraries will have to be changed:
[8:45:19] agc@db1 ~/lint 37 > cat a.c
[8:45:21] agc@db1 ~/lint 38 > make lint
lint -chapbxzF -i a.c
a.c(10): warning: function main falls off bottom without returning value 
lint -chapbxzF a.ln
printf returns value which is always ignored
[8:45:24] agc@db1 ~/lint 39 >
(Not that I'm against the change, merely mentioning that that is why some of
the utilities that I write have return's from main()).