Subject: Re: getch() memory leak fix
To: Jun-ichiro itojun Hagino <itojun@iijlab.net>
From: Julian Coleman <J.D.Coleman@newcastle.ac.uk>
List: tech-userlevel
Date: 07/31/2000 19:48:34
> 	I found the following diff in my local tree.  it it still
> 	necessary?

Not sure if that it should be called a memory leak, as __init_getch() is
only called once!  I don't see any reason to keep the return value around,
so I think it can be free()'d, yes.  Some t_getstr() calls in setterm.c look
like they could do with this too.  The one in getcap() should check against
NULL not ERR, I think.

Thanks,

J

-- 
                    My other computer also runs NetBSD
                          http://www.netbsd.org/