Subject: Re: lpr fix for hiding __ivaliduser{,_sa} from the userland
To: Jun-ichiro itojun Hagino <>
From: Klaus Klein <>
List: tech-userlevel
Date: 05/29/2000 09:17:27
Jun-ichiro itojun Hagino <> writes:

> >> 	the patch is to make __ivaliduser() and __ivaliduser_sa() (in
> >> 	lib/libc/net/rcmd.c, which is exported for lpd access control)
> >> 	static functions.
> >> 	do people think this is reasonable?  Makefile is a bit dirty.
> >> 	this is to avoid filename conflict for pathnames.h.
> >Besides your diff (checking not for _LIBC but notdef) not actually
> >making them static, you should also consider remove the leading
> >underscores which are no longer necessary; making them static already
> >is an incompatible interface change, so renaming them isn't an issue
> >either.
> >
> >Other than that, it looks fine to me.
> 	if we hide __ivaliduser(), compiled lpd binary will choke.  so I
> 	thought that we'd need to defer the "static" change until the next
> 	libc major # bump.  am I wrong?

You are right.  It was just your change description being inconsistent
with the diff that confused me.  Please go ahead and commit this