Subject: Re: lpr fix for hiding __ivaliduser{,_sa} from the userland
To: None <>
From: Klaus Klein <>
List: tech-userlevel
Date: 05/28/2000 11:14:13 writes:

> 	the patch is to make __ivaliduser() and __ivaliduser_sa() (in
> 	lib/libc/net/rcmd.c, which is exported for lpd access control)
> 	static functions.
> 	do people think this is reasonable?  Makefile is a bit dirty.
> 	this is to avoid filename conflict for pathnames.h.

Besides your diff (checking not for _LIBC but notdef) not actually
making them static, you should also consider remove the leading
underscores which are no longer necessary; making them static already
is an incompatible interface change, so renaming them isn't an issue

Other than that, it looks fine to me.