Re: [PATCH] PR standards/44921: Add errno consts for robust mutexes

[Jason Thorpe <thorpej%me.com@localhost>]

> On Mar 3, 2020, at 9:35 AM, Michał Górny <mgorny%gentoo.org@localhost> wrote:
> 
> 
> Thank you, I'll update it.  I wonder if we can catch missing entries
> automatically there.

1- Don't declare the size of the array.

2- Use designated initializers for the array elements.

3- CTASSERT that sizeof(nfsrv_v2errmap) == ELAST.

> 
>> 
>> /*
>> * Maps errno values to nfs error numbers.
>> * Use NFSERR_IO as the catch all for ones not specifically defined in
>> * RFC 1094.
>> */
>> static const u_char nfsrv_v2errmap[ELAST] = {
>>  NFSERR_PERM,  NFSERR_NOENT,   NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_NXIO,  NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_ACCES,   NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_EXIST,   NFSERR_IO,      NFSERR_NODEV,   NFSERR_NOTDIR,
>>  NFSERR_ISDIR, NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_FBIG,    NFSERR_NOSPC,   NFSERR_IO,      NFSERR_ROFS,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_NAMETOL, NFSERR_IO,      NFSERR_IO,
>>  NFSERR_NOTEMPTY, NFSERR_IO,   NFSERR_IO,      NFSERR_DQUOT,   NFSERR_STALE,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,      NFSERR_IO,      NFSERR_IO,      NFSERR_IO,
>>  NFSERR_IO,    NFSERR_IO,
>> };
>> 
>> christos
>> 
> 
> -- 
> Best regards,
> Michał Górny

-- thorpej